Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17a4fec776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ? QVariant::fromValue(p.timing.sampling_basis == SvSampleMode::samples_per_period | ||
| ? 0 : p.timing.sampling_basis == SvSampleMode::samples_per_second ? 1 : -1) |
There was a problem hiding this comment.
When an opened SCL uses the supported SecPerSample/SecPerSmp sampling basis with SmvOpts@sampleRate=true, the compiler produces SvSampleMode::seconds_per_sample, but this ternary falls through to -1. The new inspector therefore reports smpMod -1 instead of the corresponding wire value 2; handle the third known mode explicitly and reserve the fallback for genuinely unknown values.
AGENTS.md reference: AGENTS.md:L300-L301
Useful? React with 👍 / 👎.
…onservative receiver epoch gates
…r full smoke and install FAT
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88575b874f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ($sha -cnotmatch '^[0-9a-f]{40} | ||
| uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
In the windows-preview job, the run: | block ends prematurely at the dedented uses: line, leaving the SHA regex unterminated and line 403 as an invalid top-level YAML key. A YAML parse reports could not find expected ':', so GitHub cannot load this workflow and none of its firmware or Windows preview jobs can run; keep the complete SHA check inside the PowerShell block and remove the misplaced duplicate artifact step.
Useful? React with 👍 / 👎.
|
Disposition (2026-10-23): SUPERSEDED BY canonical Draft PR #286, NOT MERGED INTO
|
Source and safety
1846fd003c97bbf58e482efe11bd2a4a69a0eac7; not main.SmpPerPeriod-> smpMod=0 and e.g. smpRate=80 for 4kHz@50Hz / 4.8kHz@60Hz;SmpPerSec-> smpMod=1 and rate 4000 or 4800. Validate actual frame-rate ratio 50/60 before admitting binary SCL mode.include_sample_rate=falseremains unchanged; ASCII PROFILE SV uses established samples/second mode and resets any stale SCL wire mode.Gates